Commit graph

672 commits

Author SHA1 Message Date
YiFang Xiao b815f489d2 clean: remove config old code 2023-06-16 20:34:50 +08:00
xiaoyifang 16f853b68b
fix: qtimer release memory (#863)
* fix: memory leakage
2023-06-16 08:37:33 +08:00
shenleban tongying 35f39ea7a0
clean: convert a few trivial old SIGNAL/SLOT to new syntax 2023-06-11 11:27:49 -04:00
xiaoyifang 7e93d787b5
Merge pull request #852 from shenlebantongying/no_SIGNAL_scanpopup
clean: convert Scanpopup edictGroupRequested to new syntax
2023-06-11 23:20:16 +08:00
shenleban tongying b882ecb76c
clean: convert Scanpopup edictGroupRequested to new syntax
* old code has a SIGNAL and a SLOT both named editGroupRequested'
* rename the SIGNAL to editGroupRequest to avoid this ambiguity
2023-06-11 10:17:20 -04:00
YiFang Xiao 318e186215 fix: slob fullindex will freeze the preference dialog 2023-06-11 21:33:25 +08:00
shenleban tongying f14d28d193
clean: convert MainWindow::addGlobalAction SLOT to new syntax
Historical context: `MainWindow::addGlobalAction` was invented by

https://github.com/goldendict/goldendict/pull/482/files
2023-06-11 04:47:39 -04:00
xiaoyifang ca4664f209
fix: possible crash (#836)
* fix: possible crash when show statusbar message

* windows qt upgrade to qt6.5.1

* Update src/ui/mainstatusbar.cc

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
2023-06-10 22:26:24 +08:00
xiaoyifang dfd3a86c7f
fix: fulltext remove query word size check (#845)
* fix: fulltext remove query word size check

* fix: remove unused methods

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-10 21:02:22 +08:00
shenlebantongying ab7af55696 update initializing.ui & splash img 2023-06-10 07:40:17 -04:00
xiaoyifang a688a08eb1
Merge pull request #843 from xiaoyifang/feature/splash-2
feat: make initialize ui more human-friendly
2023-06-10 18:25:48 +08:00
YiFang Xiao 90b89acac0 feat: make initialize ui more human-friendly 2023-06-10 16:57:49 +08:00
YiFang Xiao 799370f5ef fix: adjust margin around dictionary group 2023-06-10 14:45:48 +08:00
xiaoyifang 9c1a77a3f8
fix regression: select translation line text when got focused (#841)
* fix: select translation line text when got focused

* 🎨 apply clang-format changes

* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-10 10:36:59 +08:00
YiFang Xiao fc08c16479 fix: merge history items when import history items 2023-06-09 21:57:09 +08:00
YiFang Xiao 04ed15434e fix: remove duplicate logic 2023-06-09 21:36:12 +08:00
xiaoyifang 8ecf3b6cbc
Merge pull request #837 from xiaoyifang/opt/dsl-old-logic
fix: dsl remove too old code logic
2023-06-09 20:11:08 +08:00
xiaoyifang f02fc350f8
fix: keep the application name unchanged for now (#835)
fix: Windows autostart reg entry use GoldenDict as entry name
2023-06-09 19:56:51 +08:00
xiaoyifang 9d047fea61
fix: add an --reset-windows-state option to command line (#829)
* fix: add an --reset-windows-state option to command line

* add an option
2023-06-09 19:56:04 +08:00
YiFang Xiao 6a7dd65728 fix: remove too old code logic
reasons:
1. if the replacement is important ,then the code should not care about the length (size() < 70)
2.  ' ' has been replaced with uC2A0 which is incorrect.  u00A0 is expected.
2023-06-09 19:53:34 +08:00
xiaoyifang 67ed24c61c
fix: support dsl dictionary utf encoding detection (#830)
* fix: support dsl dictionary utf encoding detection

* fix: code smells

* fix: code smells

* 🎨 apply clang-format changes

* fix: adjust linefeed

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-09 08:01:45 +08:00
YiFang Xiao c56304a2b9 fix: remove toggle main windows extra parameter
the parameter has no use right now
2023-06-08 08:30:23 +08:00
YiFang Xiao 70cd2f937d fix: remove unused configuration 2023-06-07 23:49:27 +08:00
YiFang Xiao 47cc3ced1f fix: remove the context line parameter
in release mode, this parameters are empty
2023-06-07 21:58:59 +08:00
xiaoyifang f58eb43bd2
opt: use QFontCombox instead (#781)
* opt: use QFontCombox instead

* 🎨 apply clang-format changes

* remove comment code

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-07 21:53:21 +08:00
Ren Tatsumoto e6a2c4081b
fix global translateLineText not being updated when translate line changes 2023-06-07 09:34:25 +03:00
YiFang Xiao eccc3eaf0f Revert "opt: mdx video url"
This reverts commit 2bd5194c91.

accidently merged.
2023-06-06 23:45:04 +08:00
YiFang Xiao c2ff1e804f QDomDocument changed the implementation of setContent 2023-06-06 15:37:47 +08:00
xiaoyifang e0dba5ac3b
Merge pull request #818 from shenlebantongying/expose_timer
feat: expose linux's selection clipboard delay timer to user
2023-06-05 22:46:08 +08:00
xiaoyifang 671427803a
fix: replace suggestion list with QCompleter (#808)
* fix: replace suggestionList with QCompleter


* 🎨 apply clang-format changes


* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-05 21:22:20 +08:00
YiFang Xiao dcfee63b22 fix: wikipedia query parameter is incorrect 2023-06-05 20:58:04 +08:00
shenleban tongying 6732f4630d
feat: expose linux's selection clipboard delay timer to user
* In certain programs like Chrome, the selection clipboard will update
even the user have not released mouse button.
2023-06-05 08:22:49 -04:00
shenleban tongying b06c01beeb
fix: xdxf2html converter failed to parser xml due to &nbsp;
* xml don't have &nbsp;
* in Qt5, this is not a problem because QDomDocument::setContent will
 somehow accept it.
* in Qt6, this will be rejected
2023-06-04 07:38:14 -04:00
shenleban tongying 41776d2b89
feat: add article-script.js
* like article-style.css but for javascript
2023-06-03 20:53:46 -04:00
shenleban tongying 849b1345e1
fix: define PROGRAM_DATA_DIR for cmake
* the PROGRAM_DATA_DIR is hardcoded path to /usr/share/goldendict
* Without it, resources cannot be loaded
2023-06-03 09:50:13 -04:00
xiaoyifang 87e2091214
fix: remove for loop with most one iteration (#804)
* fix: remove `for` loop with most one iteration

* 🎨 apply clang-format changes

* fix: remove `for` loop with most one iteration

* fix: code smells

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-03 20:51:38 +08:00
YiFang Xiao d6009f0e8e fix: new release check ,download url is incorrect
fix #718
2023-06-03 17:49:37 +08:00
YiFang Xiao 29403f4263 fix: code smells
🎨 apply clang-format changes

fix: code smells

🎨 apply clang-format changes

🎨 apply clang-format changes
2023-06-03 14:07:41 +08:00
YiFang Xiao 1391a8fa7e fix: invalid data access of data field
bgl_babylon.cc

fix #770
2023-06-03 14:07:41 +08:00
YiFang Xiao 0c7d7ada21 fix: invalid data access of data field
bgl_babylon.cc

fix #768
2023-06-03 14:07:41 +08:00
YiFang Xiao 49c6ae7032 opt: iconv remove unused parameter
In GoldenDict, the application uses utf-8 as the default encoding. There should be no other use.
2023-06-03 14:07:18 +08:00
xiaoyifang 5899aa7c94
fix: highlight fts search result (#792)
* fix: highlight fts search result

* 🎨 apply clang-format changes

* remove accent/diacritic handler used in fts search

* header file adjustment

* fix: qt5.15 compile

* fix: code smell

use const reference variable

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* 🎨 apply clang-format changes

* fix: code smells

🎨 apply clang-format changes

* opt: fix code smells

remove unused parameters from function `ftsIndexIsOldOrBad`

🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-03 08:29:19 +08:00
YiFang Xiao 2bd5194c91 opt: mdx video url 2023-06-02 21:47:48 +08:00
xiaoyifang ded97deb9a
Merge pull request #789 from xiaoyifang/fix/code-smells
fix: code smells
2023-06-01 21:15:43 +08:00
xiaoyifang b7edc8ed2d 🎨 apply clang-format changes 2023-06-01 11:53:45 +00:00
YiFang Xiao 002f7a02f7 fix: code smells
refactor the disabledType string build
2023-06-01 19:52:16 +08:00
xiaoyifang eefdba23ae
Merge pull request #787 from shenlebantongying/cmake_polish
cmake: polishments to be officially used
2023-06-01 14:07:58 +08:00
shenleban tongying 0c75d4f399
cmake: updates
* add USE_SYSTEM_FMT & USE_SYSTEM_TOML
* switch back to libeb
2023-06-01 01:28:45 -04:00
YiFang Xiao 978fd3ba81 opt: slob dictionary does not display goldendict headword 2023-06-01 10:55:40 +08:00
xiaoyifang c7f773c12b
Merge pull request #776 from shenlebantongying/better_defaults
Tweak some defaults
2023-05-31 18:42:55 +08:00