Commit graph

198 commits

Author SHA1 Message Date
YiFang Xiao 9e5ce992ca fix: support space and pageup/pagedown shortkey to navigate through the page 2023-07-27 08:06:48 +08:00
xiaoyifang 17cd445607
feat: customize dictionary's fullindex option with metadata.toml (#1000)
* feat: customize dictionary's fullindex option with metadata.toml

* [autofix.ci] apply automated fixes

* feat: display fulltext status in the dictionary info dialog

* [autofix.ci] apply automated fixes

* doc: add document about how to enable dictionary's fullindex feature

* Update src/metadata.cc

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>

* Update src/ui/dictinfo.ui

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>

* Update website/mkdocs.yml

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>

* Update website/docs/custom_dictionary.md

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>

* Update website/docs/custom_dictionary.md

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>

* Update website/docs/custom_dictionary.md

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>

* Update website/docs/custom_dictionary.md

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>

* Update website/docs/custom_dictionary.md

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>

* Update website/docs/custom_dictionary.md

Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>

* add images

* feat: show fulltext search status in dictionary info dialog

* Update dictinfo.cc

* [autofix.ci] apply automated fixes

* ui: change layout

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>
2023-07-26 10:03:20 +08:00
xiaoyifang d3e6018401
fix: wikipedia open blank page in edge browser (#1003)
* fix: wikipedia open blank page in edge browser

* [autofix.ci] apply automated fixes

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-07-25 23:55:41 +08:00
shenleban tongying f9b1d3fa92
fix typo of app id 2023-07-25 08:04:49 -04:00
shenleban tongying 53d82f97ca
Another various changes required by Flatpak 2023-07-24 06:58:56 -04:00
shenleban tongying a4542d8b6c
fix: a few build problems about zim/slob ,epwing (#992)
* fix: a few build problems

* slob should not depends on MAKE_ZIM_SUPPORT
* cmake failed to build when WITH_EPWING disabled.

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-07-22 13:50:57 +08:00
xiaoyifang e5f91f6a3e
feat: use parallel thread to create the fts (#980)
* feat: use parallel thread to create the fts

* [autofix.ci] apply automated fixes

* feat: use parallel thread to create the fts

* feat: add an option to control the thread count when create the fulltext

* [autofix.ci] apply automated fixes

* feat: set default parallel thread count to half the cpu numbers

* feat: initialize the default parallel threads to 1/3 of cpu cores

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-07-20 22:50:32 +08:00
xiaoyifang df4bc68248
fix: [regression]scanpopup right context menu lost dictionary list (#989)
* fix: [regression]scanpopup right context menu lost dictionary list

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-07-20 22:49:37 +08:00
shenleban tongying 8471029770
feat: use "Fusion" style on macOS by default and add option to switch between styles on Linux & macOS (#986)
* feat: use "Fusion" style on macOS by default and add option to switch between styles on Linux & macOS

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes

* feat: use "Fusion" style on macOS by default and add option to switch between styles on Linux & macOS

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-07-20 20:10:44 +08:00
shenleban tongying b5349478cf
clean: reformat everything
The next commit will add `.git-blame-ignore-revs`

https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view
2023-07-20 04:02:22 -04:00
YiFang Xiao b39d931c08 fix: sound played twice in popup dialog 2023-07-19 13:44:26 +08:00
shenleban tongying 1180f8bc32
fix: website/program should not appears in "AutoGroupByFolder" 2023-07-17 23:27:46 -04:00
xiaoyifang ec06124acb
feat: sync group widget with tab (one group per tab) (#976)
* feat: sync group widget with tab

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-07-17 08:24:02 +08:00
shenleban tongying 4be457ba2d opt: rewrite release check
* check 1 time per day on startup and no more
* use github's release api instead of scraping the html page
2023-07-16 20:32:11 +08:00
xiaoyifang ce8b8a60bb
feat: add font customization (#973)
* action: auto clang format changes

action: clang-format

* feat: add separator tab to configure the font family for the web engine.

feat: custom fonts

feat: add custom font

i18n: update crowdin translation files

* [autofix.ci] apply automated fixes

* feat: add notice about the font customization

* feat: adjust interface layout

* i18n: update transaltion source

* fix: code smells

* feat: custom font layout adjustment

* i18n: update translation items

* feat: adjust layout of custom fonts

* i18n: new

* feat: adjust layout

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2023-07-16 18:54:07 +08:00
YiFang Xiao 7037694ebc fix: code smell 2023-07-14 22:31:29 +08:00
YiFang Xiao 08454602c2 opt: add open index folder to dict info dialog 2023-07-14 22:31:29 +08:00
xiaoyifang 2ed7990531
opt: pronounce audio rewrite (#922)
* opt: pronounce audio rewrite

* 🎨 apply clang-format changes

* fix:use javscript Map to hold the dictionary audio url

* Update mainwindow.cc

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-07-13 14:49:41 +08:00
YiFang Xiao 3f968027b6 fix: warning about "Release of profile requested but WebEnginePage still not deleted"
fix #955
2023-07-12 14:36:49 +08:00
YiFang Xiao 26e7ab6baa Merge branch 'staged' of https://github.com/xiaoyifang/goldendict into staged 2023-07-12 10:25:18 +08:00
YiFang Xiao ad426ae4af fix: code smell 2023-07-12 10:23:49 +08:00
xiaoyifang 9c1413adea
Merge pull request #954 from xiaoyifang/fix/crash-restore-state
fix: a possible crash of restoreState() in linux with qt6.5.1
2023-07-12 10:00:49 +08:00
YiFang Xiao 80c30b3c54 style: code format 2023-07-12 09:50:55 +08:00
YiFang Xiao 0592d2060e fix: a possible crash of restoreState() in linux with qt6.5.1
fix #952
2023-07-11 21:38:50 +08:00
YiFang Xiao 568efee4c7 fix: unicode regex option support 2023-07-09 18:10:30 +08:00
YiFang Xiao 5ec1a66d91 fix: splash windows optimization 2023-07-08 08:59:42 +08:00
YiFang Xiao 92fa182643 fix: save audio, add opus extension 2023-07-07 20:26:40 +08:00
xiaoyifang af9563ad56
Merge pull request #923 from shenlebantongying/staged
misc fts fix
2023-07-02 12:24:19 +08:00
shenleban tongying ec566c4a3b
misc fts fixes
* config fts.enablePosition is not updated
 * update preferences layout
2023-07-01 23:41:05 -04:00
xiaoyifang 759246a86f
Merge pull request #920 from xiaoyifang/fix/status-2
fix: possible crash when show()
2023-07-02 10:00:45 +08:00
YiFang Xiao 9ab59d8713 fix: possible crash when show() 2023-07-02 08:37:28 +08:00
shenleban tongying e419962abc
doc: update fts related strings 2023-07-01 12:05:15 -04:00
xiaoyifang 2621fd694d
Merge pull request #917 from xiaoyifang/fix/statusbar
fix: statusbar crash  at some rare conditions
2023-07-01 22:59:04 +08:00
xiaoyifang 8b88ea544e
opt: add fullindex position (#916)
* opt: enable fulltext with position info

* opt: add fulltext position support

* 🎨 apply clang-format changes

* i18n: update translation entries

* opt: default enablePosition=false

* opt: fulltext search highlight

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-07-01 22:39:43 +08:00
YiFang Xiao ed8072d78f fix: statusbar at some rare conditions crash
the stacktrace show the line is parentWidget().
avoid using this the parentWidget() method.
2023-07-01 22:33:58 +08:00
xiaoyifang a878e725f2
fix: code smells in group widget (#901)
* fix: code smells in group widget

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-24 15:30:20 +08:00
YiFang Xiao 43c2cfdd65 fix: group widget null check 2023-06-23 09:28:35 +08:00
YiFang Xiao 2359352781 fix: editDictionaries tab interaction 2023-06-23 09:28:35 +08:00
YiFang Xiao aa94af4382 fix: fix double release pointer 2023-06-23 09:28:35 +08:00
YiFang Xiao f909413caa fix: code smells 2023-06-23 09:28:35 +08:00
YiFang Xiao 3b935e7660 fix: possible null object
refactor: group widget currentindex logic
2023-06-22 21:30:30 +08:00
xiaoyifang ef594117c3
opt: group widget remove all tabs (#892)
* opt: remove all group widget tabs

* 🎨 apply clang-format changes

* opt: does not elide text on tab name

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-22 17:17:57 +08:00
shenleban tongying ffe88499bb fix: macOS missing slot warning 2023-06-19 20:17:58 -04:00
shenleban tongying 1589e14b70
clean: remove redundant dictionaryNativeIcon
`dictionaryNativeIcon` was intended to access the original icon before none-square icons were transformed into squares.

`dictionaryNativeIcon` is only used in dictionaryBar, but according to the intention, it shouldn't.

In reality, `dictionaryNativeIcon` is almost always equal to `dictionaryIcon`.
2023-06-18 22:37:07 -04:00
shenleban tongying 9d19ea1ebc
feat: add -v --version flag to CLI
* also abstract version info into a standalone namespace
2023-06-17 05:00:05 -04:00
xiaoyifang 16f853b68b
fix: qtimer release memory (#863)
* fix: memory leakage
2023-06-16 08:37:33 +08:00
shenleban tongying 35f39ea7a0
clean: convert a few trivial old SIGNAL/SLOT to new syntax 2023-06-11 11:27:49 -04:00
shenleban tongying b882ecb76c
clean: convert Scanpopup edictGroupRequested to new syntax
* old code has a SIGNAL and a SLOT both named editGroupRequested'
* rename the SIGNAL to editGroupRequest to avoid this ambiguity
2023-06-11 10:17:20 -04:00
shenleban tongying f14d28d193
clean: convert MainWindow::addGlobalAction SLOT to new syntax
Historical context: `MainWindow::addGlobalAction` was invented by

https://github.com/goldendict/goldendict/pull/482/files
2023-06-11 04:47:39 -04:00
xiaoyifang ca4664f209
fix: possible crash (#836)
* fix: possible crash when show statusbar message

* windows qt upgrade to qt6.5.1

* Update src/ui/mainstatusbar.cc

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
2023-06-10 22:26:24 +08:00
shenlebantongying ab7af55696 update initializing.ui & splash img 2023-06-10 07:40:17 -04:00
xiaoyifang a688a08eb1
Merge pull request #843 from xiaoyifang/feature/splash-2
feat: make initialize ui more human-friendly
2023-06-10 18:25:48 +08:00
YiFang Xiao 90b89acac0 feat: make initialize ui more human-friendly 2023-06-10 16:57:49 +08:00
YiFang Xiao 799370f5ef fix: adjust margin around dictionary group 2023-06-10 14:45:48 +08:00
xiaoyifang 9c1a77a3f8
fix regression: select translation line text when got focused (#841)
* fix: select translation line text when got focused

* 🎨 apply clang-format changes

* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-10 10:36:59 +08:00
YiFang Xiao fc08c16479 fix: merge history items when import history items 2023-06-09 21:57:09 +08:00
xiaoyifang f02fc350f8
fix: keep the application name unchanged for now (#835)
fix: Windows autostart reg entry use GoldenDict as entry name
2023-06-09 19:56:51 +08:00
xiaoyifang 9d047fea61
fix: add an --reset-windows-state option to command line (#829)
* fix: add an --reset-windows-state option to command line

* add an option
2023-06-09 19:56:04 +08:00
YiFang Xiao c56304a2b9 fix: remove toggle main windows extra parameter
the parameter has no use right now
2023-06-08 08:30:23 +08:00
xiaoyifang f58eb43bd2
opt: use QFontCombox instead (#781)
* opt: use QFontCombox instead

* 🎨 apply clang-format changes

* remove comment code

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-07 21:53:21 +08:00
Ren Tatsumoto e6a2c4081b
fix global translateLineText not being updated when translate line changes 2023-06-07 09:34:25 +03:00
xiaoyifang e0dba5ac3b
Merge pull request #818 from shenlebantongying/expose_timer
feat: expose linux's selection clipboard delay timer to user
2023-06-05 22:46:08 +08:00
xiaoyifang 671427803a
fix: replace suggestion list with QCompleter (#808)
* fix: replace suggestionList with QCompleter


* 🎨 apply clang-format changes


* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-05 21:22:20 +08:00
shenleban tongying 6732f4630d
feat: expose linux's selection clipboard delay timer to user
* In certain programs like Chrome, the selection clipboard will update
even the user have not released mouse button.
2023-06-05 08:22:49 -04:00
xiaoyifang 87e2091214
fix: remove for loop with most one iteration (#804)
* fix: remove `for` loop with most one iteration

* 🎨 apply clang-format changes

* fix: remove `for` loop with most one iteration

* fix: code smells

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-03 20:51:38 +08:00
YiFang Xiao d6009f0e8e fix: new release check ,download url is incorrect
fix #718
2023-06-03 17:49:37 +08:00
xiaoyifang 5899aa7c94
fix: highlight fts search result (#792)
* fix: highlight fts search result

* 🎨 apply clang-format changes

* remove accent/diacritic handler used in fts search

* header file adjustment

* fix: qt5.15 compile

* fix: code smell

use const reference variable

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* 🎨 apply clang-format changes

* fix: code smells

🎨 apply clang-format changes

* opt: fix code smells

remove unused parameters from function `ftsIndexIsOldOrBad`

🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-03 08:29:19 +08:00
xiaoyifang b7edc8ed2d 🎨 apply clang-format changes 2023-06-01 11:53:45 +00:00
YiFang Xiao 002f7a02f7 fix: code smells
refactor the disabledType string build
2023-06-01 19:52:16 +08:00
shenleban tongying 7f994112b7
fix: send to mainwindow got empty word
a regression due to Input Phase change: if word is sent to
mainwindow, then definition->getWord() would be empty
2023-05-31 04:17:16 -04:00
shenleban tongying 6823254bac clean: solve a TODO about translateInputFinished 2023-05-31 07:26:43 +08:00
shenleban tongying 6c7bb05f35 clean: convert SLOT translateInputFinished to new syntax 2023-05-31 07:26:43 +08:00
shenleban tongying 0079cd2933 clean: remove unnecessary header includes
* remove all <QtGUI> which includes *everything* of Qt
* remove unused headers
2023-05-30 20:59:51 +08:00
YiFang Xiao 15e0fa087f opt: replace Mutex::Lock with QMutexLocker 2023-05-30 00:08:01 +08:00
shenleban tongying 0b746ef8eb
Revise how word is getting passed (#736)
* fix: remove InputPhrase

* opt: remove unnecessary InputPhrase

* fix: assignment issue

* fix: add handleInputWord back

* fix: does not need to trim punc

---------

Co-authored-by: YiFang Xiao <yifang.xiao@foxmail.com>
2023-05-29 00:01:54 +08:00
xiaoyifang 4eb8374a35
opt: mdx fulltext lock seperated with normal search (#759)
* opt: refactor mdx fullindex creation

* opt: incremental fulltext creation logic change

* opt: incremental fulltext creation logic change

* opt: progress of fulltext creation logic

* opt: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* 🎨 apply clang-format changes

* fix: code smell

* fix: code smell

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-29 00:01:21 +08:00
YiFang Xiao 2cbcab16ba fix: switch dictionary should change the headwords in the dialog
fix #752
2023-05-27 23:53:16 +08:00
YiFang Xiao a8b6fbc754 opt: make the searchPanel can resize to a smaller width
🎨 apply clang-format changes

opt: make the searchPanel can resize to a smaller width

🎨 apply clang-format changes

fix:remove group label in docker
2023-05-23 19:03:21 +08:00
xiaoyifang 69ff9b1177
opt: remove DiacriticFolding.txt (#713)
* opt: remove DiacriticFolding.txt

* 🎨 apply clang-format changes

* fix: remove foldedDiacritic method

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-20 10:28:43 +08:00
xiaoyifang d08d5fe576
opt: let qt handle the language direction (#709)
* opt: let qt handle the language direction

* 🎨 apply clang-format changes

* action: modify auto clang format action

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-19 19:41:27 +08:00
YiFang Xiao 1e328e0727 fix: qwarning placed in the wrong place 2023-05-19 19:40:19 +08:00
shenleban tongying d0b2349156 update .desktop and appstream xml 2023-05-18 10:27:40 +08:00
xiaoyifang d174dc16ba
opt:remove non-xapian fulltext creation logic (#643)
* opt!:remove non-xapian fulltext creation logic

BREAKING CHANGE: after this PR, xapian package will have to installed
before the compilation. on Linux, this should be libxapian-dev package.

For common users: all created fulltext which is not created by xapian
before will be recreated using the new
engine.

* fix: remove old fulltext search ui

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-17 22:29:56 +08:00
YiFang Xiao ced19b9f11 Revert "feature:webengineprofile use non off record profile"
This reverts commit e84b5aa861.
2023-05-16 04:44:48 -08:00
YiFang Xiao 3d01ded56c fix typo 2023-05-15 11:46:02 +08:00
YiFang Xiao c0aeca7254 fix: selection triggered scanpopup too early
on Ubuntu(Linux),the selection change event occured too often while the delayed time is a little small ,the result is that the popup will show up when users still selecting the text.  Increase the delayed time a little seems can solve this issue.

fix #629
2023-05-14 07:56:38 -08:00
YiFang Xiao c40d04ec5e feat: add custom transliteration support
fix #661

i18n: add new translation entries
2023-05-14 06:32:13 -08:00
YiFang Xiao 967926cee4 fix: press enter the article view does not get the focus
fix #660
2023-05-13 22:57:08 +08:00
YiFang Xiao 85f3e249f0 fix: remove code smell 2023-05-13 22:44:03 +08:00
YiFang Xiao dfd8112f76 fix: multi monitor issue
taken the changes from From 83020389c8
2023-05-13 22:44:03 +08:00
YiFang Xiao 837f8bcaf8 fix: code smell 2023-05-13 12:39:36 +08:00
YiFang Xiao 60d26e0e0f fix: the scanpopup found dictionaries mixed with mainwindows
fix #677
2023-05-13 12:39:36 +08:00
YiFang Xiao be8331afa8 opt: inspector debug message changes 2023-05-12 16:59:52 +08:00
YiFang Xiao 3a24a43410 fix: when use arrow key in foundDictionaryPanel ,jump to the target dictionary 2023-05-11 18:43:02 +08:00
yifang xiao 2b72e14b55 fix: phrase send from scanpopup should not escape again
fix #626
2023-05-11 07:08:02 +08:00
shenleban tongying 6bbb4d9971 feat(metadata): abstract metadata loader 2023-04-30 14:42:49 +08:00
xiaoyifang 42ac21af61 opt: enable pronounce button when audio is available
close #598
2023-04-30 12:01:27 +08:00
shenleban tongying ab54b72da4 fix: misc fix for auto groups by metadata.toml
* fix a crash when the type is not string
* update docs
2023-04-30 00:20:28 +08:00
xiaoyifang 94759ffb58 opt: add group by metadata
close #612
2023-04-29 20:43:27 +08:00
shenleban tongying 70fd2d18f8 clean: use new Signal Slot syntax 2023-04-29 19:15:43 +08:00