hashirama/goldendict-ng
hashirama/goldendict-ng
0
0
Fork 0
mirror of https://github.com/xiaoyifang/goldendict-ng.git synced 2024-12-19 12:14:06 +00:00
Code Issues Actions 1 Projects Releases Wiki Activity
5648 commits 23 branches 636 tags 257 MiB
Commit graph

123 commits

Author SHA1 Message Date
xiaoyifang 8798f04312
Merge pull request #1210 from xiaoyifang/opt/code-smell 
refactor: use static class method instead of instance method
 2023-10-07 21:51:26 +08:00
YiFang Xiao b754a24c6c refactor: reduce nested loop depth 2023-10-07 21:36:40 +08:00
YiFang Xiao da9d90efec fix: word zoom does not work in completer 2023-10-07 21:13:12 +08:00
xiaoyifang ef6e878a31
opt: add translation windows when invoked from console (#1173) 
* opt: add an extra console argument to specify the translation windows

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

---------

Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
 2023-09-30 11:40:40 +08:00
xiaoyifang 19e848ec50
fix: enter event in translate textline (#1158) 
* fix: enter event in translate textline

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
 2023-09-21 07:44:58 +08:00
xiaoyifang 6f06f083da
opt: make translateline in toolbar the same height as toolbar (#1140) 
* opt: make  translateline in toolbar the same height as toolbar

* Update src/ui/mainwindow.cc

* Update src/ui/mainwindow.cc
 2023-09-13 15:44:57 +08:00
xiaoyifang 8dd9119aec
fix: translatebox press Enter does not translate the selected item (#1134) 
* fix: translatebox press Enter does not translate the selected item

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
 2023-09-10 17:52:18 +08:00
YiFang Xiao 0683afa2b0 opt: add Ctrl+Shift+S to stop the current playing sound 
[autofix.ci] apply automated fixes
 2023-08-25 08:44:21 +08:00
xiaoyifang 77348c7f46
opt: remove invalid index on exit (#1071) 
* opt: remove invalid index on exit

* [autofix.ci] apply automated fixes

* fix: code smells

* opt: remove invalid dictionary index

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
 2023-08-17 23:17:53 +08:00
YiFang Xiao 06fc833146 fix: qcompleter lost signal when qlineedit lost focus 
fix #1062
 2023-08-12 12:39:23 +08:00
YiFang Xiao 2c3f22630b Revert "fix: no need to installEventFilter( this) to itself" 
This reverts commit 7806a86e22.
 2023-08-12 12:35:12 +08:00
YiFang Xiao 51a050c43b fix: remove old unnecessary logic which blocks updating Windows Title 2023-08-10 23:59:29 +08:00
YiFang Xiao 7806a86e22 fix: no need to installEventFilter( this) to itself 2023-08-08 20:41:30 +08:00
shenlebantongying 36ca0d0994 fix: adjust the order of Mainwindow's show() and restoreState/restoreGeometry 2023-08-06 09:37:18 -04:00
YiFang Xiao 73cbbac6f9 fix: translate line in floatable toolbar will lose focus 
fix #1001
 2023-08-01 19:26:11 +08:00
shenlebantongying 1ffd729614 fix: Qt6.4/5's maximize bug https://bugreports.qt.io/browse/QTBUG-115074 2023-07-27 23:27:46 -04:00
xiaoyifang 88117306a7 Revert "fix: restore maximize geometry (#1013)" 
This reverts commit cd560f85fd.
 2023-07-27 23:20:16 +08:00
xiaoyifang cd560f85fd
fix: restore maximize geometry (#1013) 
* fix: restore maximize geometry

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
 2023-07-27 17:09:06 +08:00
shenleban tongying 6539775c4f
use qt header 2023-07-26 20:48:50 -04:00
autofix-ci[bot] 1502dc318a
[autofix.ci] apply automated fixes 2023-07-27 00:29:51 +00:00
YiFang Xiao 9e5ce992ca fix: support space and pageup/pagedown shortkey to navigate through the page 2023-07-27 08:06:48 +08:00
shenleban tongying f9b1d3fa92
fix typo of app id 2023-07-25 08:04:49 -04:00
shenleban tongying 53d82f97ca
Another various changes required by Flatpak 2023-07-24 06:58:56 -04:00
shenleban tongying 8471029770
feat: use "Fusion" style on macOS by default and add option to switch between styles on Linux & macOS (#986) 
* feat: use "Fusion" style on macOS by default and add option to switch between styles on Linux & macOS

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes

* feat: use "Fusion" style on macOS by default and add option to switch between styles on Linux & macOS

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
 2023-07-20 20:10:44 +08:00
shenleban tongying b5349478cf
clean: reformat everything 
The next commit will add `.git-blame-ignore-revs`

https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view
 2023-07-20 04:02:22 -04:00
YiFang Xiao b39d931c08 fix: sound played twice in popup dialog 2023-07-19 13:44:26 +08:00
xiaoyifang ec06124acb
feat: sync group widget with tab (one group per tab) (#976) 
* feat: sync group widget with tab

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
 2023-07-17 08:24:02 +08:00
shenleban tongying 4be457ba2d opt: rewrite release check 
* check 1 time per day on startup and no more
* use github's release api instead of scraping the html page
 2023-07-16 20:32:11 +08:00
xiaoyifang ce8b8a60bb
feat: add font customization (#973) 
* action: auto clang format changes

action: clang-format

* feat: add separator tab to configure the font family for the web engine.

feat: custom fonts

feat: add custom font

i18n: update crowdin translation files

* [autofix.ci] apply automated fixes

* feat: add notice about the font customization

* feat: adjust interface layout

* i18n: update transaltion source

* fix: code smells

* feat: custom font layout adjustment

* i18n: update translation items

* feat: adjust layout of custom fonts

* i18n: new

* feat: adjust layout

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
 2023-07-16 18:54:07 +08:00
xiaoyifang 2ed7990531
opt: pronounce audio rewrite (#922) 
* opt: pronounce audio rewrite

* 🎨 apply clang-format changes

* fix:use javscript Map to hold the dictionary audio url

* Update mainwindow.cc

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
 2023-07-13 14:49:41 +08:00
YiFang Xiao 3f968027b6 fix: warning about "Release of profile requested but WebEnginePage still not deleted" 
fix #955
 2023-07-12 14:36:49 +08:00
YiFang Xiao 0592d2060e fix: a possible crash of restoreState() in linux with qt6.5.1 
fix #952
 2023-07-11 21:38:50 +08:00
xiaoyifang 16f853b68b
fix: qtimer release memory (#863) 
* fix: memory leakage
 2023-06-16 08:37:33 +08:00
shenleban tongying b882ecb76c
clean: convert Scanpopup edictGroupRequested to new syntax 
* old code has a SIGNAL and a SLOT both named editGroupRequested'
* rename the SIGNAL to editGroupRequest to avoid this ambiguity
 2023-06-11 10:17:20 -04:00
shenleban tongying f14d28d193
clean: convert MainWindow::addGlobalAction SLOT to new syntax 
Historical context: `MainWindow::addGlobalAction` was invented by

https://github.com/goldendict/goldendict/pull/482/files
 2023-06-11 04:47:39 -04:00
YiFang Xiao 799370f5ef fix: adjust margin around dictionary group 2023-06-10 14:45:48 +08:00
xiaoyifang 9c1a77a3f8
fix regression: select translation line text when got focused (#841) 
* fix: select translation line text when got focused

* 🎨 apply clang-format changes

* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
 2023-06-10 10:36:59 +08:00
YiFang Xiao fc08c16479 fix: merge history items when import history items 2023-06-09 21:57:09 +08:00
xiaoyifang f02fc350f8
fix: keep the application name unchanged for now (#835) 
fix: Windows autostart reg entry use GoldenDict as entry name
 2023-06-09 19:56:51 +08:00
xiaoyifang 9d047fea61
fix: add an --reset-windows-state option to command line (#829) 
* fix: add an --reset-windows-state option to command line

* add an option
 2023-06-09 19:56:04 +08:00
YiFang Xiao c56304a2b9 fix: remove toggle main windows extra parameter 
the parameter has no use right now
 2023-06-08 08:30:23 +08:00
Ren Tatsumoto e6a2c4081b
fix global translateLineText not being updated when translate line changes 2023-06-07 09:34:25 +03:00
xiaoyifang 671427803a
fix: replace suggestion list with QCompleter (#808) 
* fix: replace suggestionList with QCompleter


* 🎨 apply clang-format changes


* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
 2023-06-05 21:22:20 +08:00
xiaoyifang 87e2091214
fix: remove for loop with most one iteration (#804) 
* fix: remove `for` loop with most one iteration

* 🎨 apply clang-format changes

* fix: remove `for` loop with most one iteration

* fix: code smells

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
 2023-06-03 20:51:38 +08:00
YiFang Xiao d6009f0e8e fix: new release check ,download url is incorrect 
fix #718
 2023-06-03 17:49:37 +08:00
shenleban tongying 6823254bac clean: solve a TODO about translateInputFinished 2023-05-31 07:26:43 +08:00
shenleban tongying 6c7bb05f35 clean: convert SLOT translateInputFinished to new syntax 2023-05-31 07:26:43 +08:00
shenleban tongying 0079cd2933 clean: remove unnecessary header includes 
* remove all <QtGUI> which includes *everything* of Qt
* remove unused headers
 2023-05-30 20:59:51 +08:00
shenleban tongying 0b746ef8eb
Revise how word is getting passed (#736) 
* fix: remove InputPhrase

* opt: remove unnecessary InputPhrase

* fix: assignment issue

* fix: add handleInputWord back

* fix: does not need to trim punc

---------

Co-authored-by: YiFang Xiao <yifang.xiao@foxmail.com>
 2023-05-29 00:01:54 +08:00
xiaoyifang 4eb8374a35
opt: mdx fulltext lock seperated with normal search (#759) 
* opt: refactor mdx fullindex creation

* opt: incremental fulltext creation logic change

* opt: incremental fulltext creation logic change

* opt: progress of fulltext creation logic

* opt: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* 🎨 apply clang-format changes

* fix: code smell

* fix: code smell

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
 2023-05-29 00:01:21 +08:00
YiFang Xiao a8b6fbc754 opt: make the searchPanel can resize to a smaller width 
🎨 apply clang-format changes

opt: make the searchPanel can resize to a smaller width

🎨 apply clang-format changes

fix:remove group label in docker
 2023-05-23 19:03:21 +08:00
xiaoyifang d08d5fe576
opt: let qt handle the language direction (#709) 
* opt: let qt handle the language direction

* 🎨 apply clang-format changes

* action: modify auto clang format action

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
 2023-05-19 19:41:27 +08:00
YiFang Xiao 1e328e0727 fix: qwarning placed in the wrong place 2023-05-19 19:40:19 +08:00
shenleban tongying d0b2349156 update .desktop and appstream xml 2023-05-18 10:27:40 +08:00
xiaoyifang d174dc16ba
opt:remove non-xapian fulltext creation logic (#643) 
* opt!:remove non-xapian fulltext creation logic

BREAKING CHANGE: after this PR, xapian package will have to installed
before the compilation. on Linux, this should be libxapian-dev package.

For common users: all created fulltext which is not created by xapian
before will be recreated using the new
engine.

* fix: remove old fulltext search ui

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
 2023-05-17 22:29:56 +08:00
YiFang Xiao ced19b9f11 Revert "feature:webengineprofile use non off record profile" 
This reverts commit e84b5aa861.
 2023-05-16 04:44:48 -08:00
YiFang Xiao 967926cee4 fix: press enter the article view does not get the focus 
fix #660
 2023-05-13 22:57:08 +08:00
YiFang Xiao 3a24a43410 fix: when use arrow key in foundDictionaryPanel ,jump to the target dictionary 2023-05-11 18:43:02 +08:00
yifang xiao 2b72e14b55 fix: phrase send from scanpopup should not escape again 
fix #626
 2023-05-11 07:08:02 +08:00
shenleban tongying 70fd2d18f8 clean: use new Signal Slot syntax 2023-04-29 19:15:43 +08:00
shenleban tongying 6498bd4f17 clean: convert navPronounce connect to new syntax 2023-04-29 19:15:19 +08:00
YiFang Xiao 617589d09c fix:unified the cache/directory 
supplement to a82ce2a86f
 2023-04-27 13:25:57 +08:00
xiaoyifang a82ce2a86f opt: use unified cache dir 
seperate the persistentstoragepath with cachepath
 2023-04-26 07:45:48 +08:00
xiaoyifang 04260c1fbe fix: can not remove favorite word in popup 
this bug was existed for a long time
 2023-04-25 23:07:22 +08:00
xiaoyifang 19889bfa9b opt:add a statusbar notification when finshed save article 
fix #554
 2023-04-25 22:22:30 +08:00
shenleban tongying d0ae253c27 docs: various updates 
* isolate Help related code into help.hh
* update website & README.md
 2023-04-22 18:21:14 +08:00
shenleban tongying 3f3ba6eee1 refactor: reduce dependency on mainwindow.hh 
* editdictionaries.cc and dictheadwords.cc doesn't actually need it
* fulltextsearch has a useless static_cast
 2023-04-20 19:53:17 +08:00
shenleban tongying 5c5db459b5 feat(cli): implement --toggle-scan-popup command line option 2023-04-18 17:36:42 +08:00
Xiao YiFang 14c4366839 fix: when input word in translateline and press Enter 
can not type word directly again.

fix:#185
 2023-04-18 16:08:32 +08:00
Xiao YiFang 75b0a92be7 fix: remove unused windowsstyle.cc(.hh) 
fix #512
 2023-04-18 16:04:54 +08:00
shenleban tongying 03af31c6fc
refactor: move common/base/utils into /src/common/ 2023-04-17 20:41:47 -04:00
shenleban tongying b602bc0e9f fix(qmake): macOS build 2023-04-17 20:00:36 -04:00
shenleban tongying 8b8ad5d23d
refactor: move all ui related files to /src/ui/ 2023-04-17 19:11:58 -04:00
Renamed from src/mainwindow.cc (Browse further)