Commit graph

703 commits

Author SHA1 Message Date
YiFang Xiao 6a7dd65728 fix: remove too old code logic
reasons:
1. if the replacement is important ,then the code should not care about the length (size() < 70)
2.  ' ' has been replaced with uC2A0 which is incorrect.  u00A0 is expected.
2023-06-09 19:53:34 +08:00
xiaoyifang 67ed24c61c
fix: support dsl dictionary utf encoding detection (#830)
* fix: support dsl dictionary utf encoding detection

* fix: code smells

* fix: code smells

* 🎨 apply clang-format changes

* fix: adjust linefeed

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-09 08:01:45 +08:00
YiFang Xiao c56304a2b9 fix: remove toggle main windows extra parameter
the parameter has no use right now
2023-06-08 08:30:23 +08:00
YiFang Xiao 70cd2f937d fix: remove unused configuration 2023-06-07 23:49:27 +08:00
YiFang Xiao 47cc3ced1f fix: remove the context line parameter
in release mode, this parameters are empty
2023-06-07 21:58:59 +08:00
xiaoyifang f58eb43bd2
opt: use QFontCombox instead (#781)
* opt: use QFontCombox instead

* 🎨 apply clang-format changes

* remove comment code

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-07 21:53:21 +08:00
Ren Tatsumoto e6a2c4081b
fix global translateLineText not being updated when translate line changes 2023-06-07 09:34:25 +03:00
YiFang Xiao eccc3eaf0f Revert "opt: mdx video url"
This reverts commit 2bd5194c91.

accidently merged.
2023-06-06 23:45:04 +08:00
YiFang Xiao c2ff1e804f QDomDocument changed the implementation of setContent 2023-06-06 15:37:47 +08:00
xiaoyifang e0dba5ac3b
Merge pull request #818 from shenlebantongying/expose_timer
feat: expose linux's selection clipboard delay timer to user
2023-06-05 22:46:08 +08:00
xiaoyifang 671427803a
fix: replace suggestion list with QCompleter (#808)
* fix: replace suggestionList with QCompleter


* 🎨 apply clang-format changes


* fix: code smells

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-05 21:22:20 +08:00
YiFang Xiao dcfee63b22 fix: wikipedia query parameter is incorrect 2023-06-05 20:58:04 +08:00
shenleban tongying 6732f4630d
feat: expose linux's selection clipboard delay timer to user
* In certain programs like Chrome, the selection clipboard will update
even the user have not released mouse button.
2023-06-05 08:22:49 -04:00
shenleban tongying b06c01beeb
fix: xdxf2html converter failed to parser xml due to &nbsp;
* xml don't have &nbsp;
* in Qt5, this is not a problem because QDomDocument::setContent will
 somehow accept it.
* in Qt6, this will be rejected
2023-06-04 07:38:14 -04:00
shenleban tongying 41776d2b89
feat: add article-script.js
* like article-style.css but for javascript
2023-06-03 20:53:46 -04:00
shenleban tongying 849b1345e1
fix: define PROGRAM_DATA_DIR for cmake
* the PROGRAM_DATA_DIR is hardcoded path to /usr/share/goldendict
* Without it, resources cannot be loaded
2023-06-03 09:50:13 -04:00
xiaoyifang 87e2091214
fix: remove for loop with most one iteration (#804)
* fix: remove `for` loop with most one iteration

* 🎨 apply clang-format changes

* fix: remove `for` loop with most one iteration

* fix: code smells

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-03 20:51:38 +08:00
YiFang Xiao d6009f0e8e fix: new release check ,download url is incorrect
fix #718
2023-06-03 17:49:37 +08:00
YiFang Xiao 29403f4263 fix: code smells
🎨 apply clang-format changes

fix: code smells

🎨 apply clang-format changes

🎨 apply clang-format changes
2023-06-03 14:07:41 +08:00
YiFang Xiao 1391a8fa7e fix: invalid data access of data field
bgl_babylon.cc

fix #770
2023-06-03 14:07:41 +08:00
YiFang Xiao 0c7d7ada21 fix: invalid data access of data field
bgl_babylon.cc

fix #768
2023-06-03 14:07:41 +08:00
YiFang Xiao 49c6ae7032 opt: iconv remove unused parameter
In GoldenDict, the application uses utf-8 as the default encoding. There should be no other use.
2023-06-03 14:07:18 +08:00
xiaoyifang 5899aa7c94
fix: highlight fts search result (#792)
* fix: highlight fts search result

* 🎨 apply clang-format changes

* remove accent/diacritic handler used in fts search

* header file adjustment

* fix: qt5.15 compile

* fix: code smell

use const reference variable

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* 🎨 apply clang-format changes

* fix: code smells

🎨 apply clang-format changes

* opt: fix code smells

remove unused parameters from function `ftsIndexIsOldOrBad`

🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-03 08:29:19 +08:00
YiFang Xiao 2bd5194c91 opt: mdx video url 2023-06-02 21:47:48 +08:00
xiaoyifang ded97deb9a
Merge pull request #789 from xiaoyifang/fix/code-smells
fix: code smells
2023-06-01 21:15:43 +08:00
xiaoyifang b7edc8ed2d 🎨 apply clang-format changes 2023-06-01 11:53:45 +00:00
YiFang Xiao 002f7a02f7 fix: code smells
refactor the disabledType string build
2023-06-01 19:52:16 +08:00
xiaoyifang eefdba23ae
Merge pull request #787 from shenlebantongying/cmake_polish
cmake: polishments to be officially used
2023-06-01 14:07:58 +08:00
shenleban tongying 0c75d4f399
cmake: updates
* add USE_SYSTEM_FMT & USE_SYSTEM_TOML
* switch back to libeb
2023-06-01 01:28:45 -04:00
YiFang Xiao 978fd3ba81 opt: slob dictionary does not display goldendict headword 2023-06-01 10:55:40 +08:00
xiaoyifang c7f773c12b
Merge pull request #776 from shenlebantongying/better_defaults
Tweak some defaults
2023-05-31 18:42:55 +08:00
shenleban tongying 7f994112b7
fix: send to mainwindow got empty word
a regression due to Input Phase change: if word is sent to
mainwindow, then definition->getWord() would be empty
2023-05-31 04:17:16 -04:00
shenleban tongying d72a8540d4
feat: tweak some defaults
* enable DSL's alwaysExpandOptionalParts by default
* enable both wikipedia & wikitionary by default
* disable hotkey for macOS by default (they have troubles in new macOS)
* update default websites, remove ones that no long accessible
* add default DictD protocal server
2023-05-30 23:54:43 -04:00
shenleban tongying b7f0e5448b
fix: modern style's .gddictname 2023-05-30 21:22:08 -04:00
xiaoyifang 4147770f85
Opt: ftshelper refactor (#760)
* opt: remove useless ftshelper methods

🎨 apply clang-format changes

opt: slob use xapian as fulltext engine

🎨 apply clang-format changes

opt: refactor ftshelper

🎨 apply clang-format changes

* opt: refactor ftshelper

remove unused variabes and functions.

* 🎨 apply clang-format changes

* opt: refactor ftshelper

remove unused variabes and functions.

* opt: refactor ftshelper

remove unused variabes and functions.

🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-31 07:42:31 +08:00
shenleban tongying 6823254bac clean: solve a TODO about translateInputFinished 2023-05-31 07:26:43 +08:00
shenleban tongying 6c7bb05f35 clean: convert SLOT translateInputFinished to new syntax 2023-05-31 07:26:43 +08:00
shenleban tongying 0079cd2933 clean: remove unnecessary header includes
* remove all <QtGUI> which includes *everything* of Qt
* remove unused headers
2023-05-30 20:59:51 +08:00
YiFang Xiao 15e0fa087f opt: replace Mutex::Lock with QMutexLocker 2023-05-30 00:08:01 +08:00
shenleban tongying 0b746ef8eb
Revise how word is getting passed (#736)
* fix: remove InputPhrase

* opt: remove unnecessary InputPhrase

* fix: assignment issue

* fix: add handleInputWord back

* fix: does not need to trim punc

---------

Co-authored-by: YiFang Xiao <yifang.xiao@foxmail.com>
2023-05-29 00:01:54 +08:00
xiaoyifang 4eb8374a35
opt: mdx fulltext lock seperated with normal search (#759)
* opt: refactor mdx fullindex creation

* opt: incremental fulltext creation logic change

* opt: incremental fulltext creation logic change

* opt: progress of fulltext creation logic

* opt: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* fix: code smell

* 🎨 apply clang-format changes

* fix: code smell

* fix: code smell

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-29 00:01:21 +08:00
xiaoyifang 966b477b26 🎨 apply clang-format changes 2023-05-28 15:50:08 +08:00
YiFang Xiao cfec24f4bb opt: use auto and for range in building index 2023-05-28 15:50:08 +08:00
YiFang Xiao 2cbcab16ba fix: switch dictionary should change the headwords in the dialog
fix #752
2023-05-27 23:53:16 +08:00
xiaoyifang 3858932ec4
feat!: add libzim dependency (#725)
* feat!: add libzim dependency

* 🎨 apply clang-format changes

* action: add libzim dependency to action

* feat!: change dependency folder

* action: add zim support

* feat!: add libzim support

* action: fix sonarcloud check

* doc: add libzim readme

* action: cmake build

* action: cmake check

* fix: code smell

* action: cmake check

* action: cmake on Macos

* action: cmake on Macos

* feat: use libzim to read title and description

* 🎨 apply clang-format changes

* feat: split zim file support

* feat: loadArticle refactor

* 🎨 apply clang-format changes

* 🎨 apply clang-format changes

* feat: update library and goldendict.pro

* 🎨 apply clang-format changes

* fix:word count

* 🎨 apply clang-format changes

* fix: video src url subsititue

* 🎨 apply clang-format changes

* zim: headword is not usually a valid

it is from title and url.

* fix: remove nested try catch

* zim: fix resource loading issue.

* 🎨 apply clang-format changes

* action: remove libao

* zim: process url

some old zim dictionary url does not contain namespace such as
/C/url

make the old and new zim dictionary's url consistent without the leading
../C/  etc.

* 🎨 apply clang-format changes

* zim: process url

remove leading dot and slash
such as ../-/assets  ,remove ../

* 🎨 apply clang-format changes

* zim: remove resourceIndex creation

use libzim to read the resource directly.

* zim: only iterate all the articles

* 🎨 apply clang-format changes

* fix: code smell

* 🎨 apply clang-format changes

* zim: refactor method to convert url to wstring

* 🎨 apply clang-format changes

* fix:code smell

* 🎨 apply clang-format changes

* zim: update windows dependencies

* zim: add mutex lock

* 🎨 apply clang-format changes

* fix: code smell

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-05-27 12:12:16 +08:00
YiFang Xiao fe29fdddc1 opt: add command line option --no-tts
when specified, the speech tab in the sources dialog will be disabled.

close #747
2023-05-27 12:11:37 +08:00
xiaoyifang defc2447cf
opt: convert escape string to rawstring (#749)
* opt: convert escape string to rawstring

* 🎨 apply clang-format changes

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-05-27 00:27:50 +08:00
xiaoyifang 6567e1583f
fix: langcoder trigger a crash (#746)
* fix: langcoder trigger a crash

* 🎨 apply clang-format changes

* fix: move static delcaration into the class

* Update langcoder.hh

* fix: refactor code in langcoder

* 🎨 apply clang-format changes

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
2023-05-26 23:55:33 +08:00
YiFang Xiao d3cf46e469 clean code 2023-05-23 19:40:37 +08:00
YiFang Xiao 8b1b2a1628 fix: possible dsl languageForId issue
🎨 apply clang-format changes

action: restrict to current repositroy

other people's repository has no permission to commit fix

fix: refactor langcoder method

🎨 apply clang-format changes

🎨 apply clang-format changes

🎨 apply clang-format changes

fix: code smell

🎨 apply clang-format changes

fix: adjust zlib link on Windows

fix: refactor langcoder structure
2023-05-23 19:03:25 +08:00
YiFang Xiao a8b6fbc754 opt: make the searchPanel can resize to a smaller width
🎨 apply clang-format changes

opt: make the searchPanel can resize to a smaller width

🎨 apply clang-format changes

fix:remove group label in docker
2023-05-23 19:03:21 +08:00
YiFang Xiao 5188ebd646 opt: add extra check about the existence of metadata file 2023-05-21 18:18:46 +08:00
xiaoyifang f562b9bb5f
fix: lingua request error will lost a finish signal (#734)
* fix: lingua request error will lost a finish signal

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-21 16:31:05 +08:00
shenleban tongying 23be164bbe fix: access optional without checking the existence 2023-05-21 16:30:19 +08:00
xiaoyifang 715512eda3
feat: allow to customize dictionary name (#722)
* feat: allow to customize dictionary name

* 🎨 apply clang-format changes

* fix: code smell

* feat: allow to set custom dictionary name

* 🎨 apply clang-format changes

* feat: add doc for customizing dictionary name

* 🎨 apply clang-format changes

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-20 22:33:20 +08:00
xiaoyifang 39992d8284
fix: open epwing dictionary folder (#724)
* fix: open epwing dictionary folder

check whether the current path is dir already

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-20 22:26:33 +08:00
shenleban tongying 329737f1cb opt: replace some QString + arg() with {fmt} in article_maker 2023-05-20 11:46:29 +08:00
xiaoyifang 69ff9b1177
opt: remove DiacriticFolding.txt (#713)
* opt: remove DiacriticFolding.txt

* 🎨 apply clang-format changes

* fix: remove foldedDiacritic method

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-20 10:28:43 +08:00
xiaoyifang d08d5fe576
opt: let qt handle the language direction (#709)
* opt: let qt handle the language direction

* 🎨 apply clang-format changes

* action: modify auto clang format action

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-19 19:41:27 +08:00
YiFang Xiao 1e328e0727 fix: qwarning placed in the wrong place 2023-05-19 19:40:19 +08:00
shenleban tongying d0b2349156 update .desktop and appstream xml 2023-05-18 10:27:40 +08:00
xiaoyifang d174dc16ba
opt:remove non-xapian fulltext creation logic (#643)
* opt!:remove non-xapian fulltext creation logic

BREAKING CHANGE: after this PR, xapian package will have to installed
before the compilation. on Linux, this should be libxapian-dev package.

For common users: all created fulltext which is not created by xapian
before will be recreated using the new
engine.

* fix: remove old fulltext search ui

* 🎨 apply clang-format changes

---------

Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-05-17 22:29:56 +08:00
YiFang Xiao e66f6d6404 opt: redirect the log to the current console
🎨 apply clang-format changes
2023-05-17 01:00:19 +08:00
YiFang Xiao ced19b9f11 Revert "feature:webengineprofile use non off record profile"
This reverts commit e84b5aa861.
2023-05-16 04:44:48 -08:00
YiFang Xiao 5fdf672d53 fix: rename customtransliteration from .cpp to .cc 2023-05-15 04:52:09 -08:00
YiFang Xiao 3d01ded56c fix typo 2023-05-15 11:46:02 +08:00
YiFang Xiao c0aeca7254 fix: selection triggered scanpopup too early
on Ubuntu(Linux),the selection change event occured too often while the delayed time is a little small ,the result is that the popup will show up when users still selecting the text.  Increase the delayed time a little seems can solve this issue.

fix #629
2023-05-14 07:56:38 -08:00
YiFang Xiao ca8dc576cd fix:code smell 2023-05-14 06:32:13 -08:00
YiFang Xiao c40d04ec5e feat: add custom transliteration support
fix #661

i18n: add new translation entries
2023-05-14 06:32:13 -08:00
YiFang Xiao 126e76ee62 fix: fulltext search,found dictionaries update 2023-05-14 14:31:30 +08:00
YiFang Xiao 821cceef1d fix: log-to-file does not work in multithread 2023-05-14 07:32:01 +08:00
xiaoyifang 6e52ae601f opt: refactor log file write 2023-05-14 07:32:01 +08:00
YiFang Xiao 967926cee4 fix: press enter the article view does not get the focus
fix #660
2023-05-13 22:57:08 +08:00
YiFang Xiao 85f3e249f0 fix: remove code smell 2023-05-13 22:44:03 +08:00
YiFang Xiao dfd8112f76 fix: multi monitor issue
taken the changes from From 83020389c8
2023-05-13 22:44:03 +08:00
YiFang Xiao 3265912b28 fix: enable font antialias
fix #315
2023-05-13 14:37:49 +08:00
YiFang Xiao 837f8bcaf8 fix: code smell 2023-05-13 12:39:36 +08:00
YiFang Xiao 60d26e0e0f fix: the scanpopup found dictionaries mixed with mainwindows
fix #677
2023-05-13 12:39:36 +08:00
YiFang Xiao 301db81bd4 opt: move auto release guard to the variable
by this way, developer will have a more clear view about what will happen when released
2023-05-12 16:59:52 +08:00
YiFang Xiao be8331afa8 opt: inspector debug message changes 2023-05-12 16:59:52 +08:00
YiFang Xiao 91a5696361 opt: no need to throw warning when invoke RegisterHotKey 2023-05-12 16:59:52 +08:00
YiFang Xiao d1f5024b2b fix: add default value to js gdMakeArticleActive invoke 2023-05-12 09:20:19 +08:00
YiFang Xiao 3a24a43410 fix: when use arrow key in foundDictionaryPanel ,jump to the target dictionary 2023-05-11 18:43:02 +08:00
yifang xiao 2b72e14b55 fix: phrase send from scanpopup should not escape again
fix #626
2023-05-11 07:08:02 +08:00
yifang xiao b495a1006f opt: only enable highlight dictionary name on modern style 2023-05-09 12:32:09 +00:00
YiFang Xiao 9c22e7bb21 clean: remove useless comment 2023-05-09 06:16:41 +08:00
xiaoyifang f25bee96e5 fix:startdict parse html incorrect
stardict/xdxf use QDomDocument to parse the html. which result with incorrect html structure.
2023-05-09 06:16:41 +08:00
xiaoyifang c11cff46f0 opt:style changes 2023-05-09 06:16:41 +08:00
YiFang Xiao 482379e5c7 opt: the relative position will make the absolute position work as expected 2023-05-08 13:27:01 +08:00
xiaoyifang eee71f6cdf opt: remove unneccessary translation and QString conversion 2023-05-08 00:31:21 +08:00
xiaoyifang e8b5e8d19a opt : add padding to modern style 2023-05-07 16:54:15 +08:00
xiaoyifang ce8f5eeb7f fix:use a different socketname 2023-05-06 18:14:08 +08:00
xiaoyifang bbec4685f8 fix:epwing navigation reference to invalid position 2023-05-05 08:24:00 +08:00
xiaoyifang 2f22aa1580 fix:qtexttospeech crash when initialized 2023-05-03 08:59:45 +08:00
xiaoyifang 27f15f26ea opt: refactor code to conform to style 2023-05-02 15:53:41 +08:00
xiaoyifang c969418497 feat: add breakpad crash support 2023-05-02 15:53:41 +08:00
shenlebantongying 3dd0c83794 fix: other words chopped because url chopping doesn't check condition. 2023-05-02 12:59:48 +08:00
shenleban tongying 6bbb4d9971 feat(metadata): abstract metadata loader 2023-04-30 14:42:49 +08:00
xiaoyifang cce633b2cc opt:refactor an implict string conversion to a purposeful name
fix #586
2023-04-30 13:45:11 +08:00
xiaoyifang 42ac21af61 opt: enable pronounce button when audio is available
close #598
2023-04-30 12:01:27 +08:00