shenleban tongying
fa27f32146
clean: unify how data added to dataRequestInstant
2023-06-24 17:36:10 -04:00
YiFang Xiao
8628a12e5f
fix:dsl language parse issue
...
fix #902
2023-06-24 20:44:29 +08:00
xiaoyifang
a878e725f2
fix: code smells in group widget ( #901 )
...
* fix: code smells in group widget
* 🎨 apply clang-format changes
---------
Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-24 15:30:20 +08:00
xiaoyifang
5d3f1a3e3d
Merge pull request #899 from shenlebantongying/datareq_append_str
...
clean: unify DataRequest string data appends
2023-06-24 14:28:01 +08:00
xiaoyifang
6a9ed739e8
Merge pull request #900 from shenlebantongying/xdxf_fix
...
feat: XDXF: distinguish `ex_orig` and `ex_tran`
2023-06-24 09:56:19 +08:00
shenleban tongying
48f2c94d0c
feat: XDXF: distinguish ex_orig
and ex_tran
...
* this will make xdxf_ex_marked to inherit color, thus don't set it
to black.
2023-06-23 14:35:49 -04:00
shenleban tongying
e06606ba3c
clean: unify DataRequest string data appends
2023-06-23 12:23:32 -04:00
YiFang Xiao
43c2cfdd65
fix: group widget null check
2023-06-23 09:28:35 +08:00
YiFang Xiao
2359352781
fix: editDictionaries tab interaction
2023-06-23 09:28:35 +08:00
YiFang Xiao
aa94af4382
fix: fix double release pointer
2023-06-23 09:28:35 +08:00
YiFang Xiao
4d452e7a63
fix: tts null check
2023-06-23 09:28:35 +08:00
YiFang Xiao
f909413caa
fix: code smells
2023-06-23 09:28:35 +08:00
YiFang Xiao
0a9a053945
opt: enable breakpad on macos
...
action: add macos breakpad workflow
action: breakpad
action: breakpad
action: breakpad dmg
action: breakpad
action: macos breakpad action does not need to build automatically
2023-06-23 09:28:35 +08:00
YiFang Xiao
3b935e7660
fix: possible null object
...
refactor: group widget currentindex logic
2023-06-22 21:30:30 +08:00
xiaoyifang
ef594117c3
opt: group widget remove all tabs ( #892 )
...
* opt: remove all group widget tabs
* 🎨 apply clang-format changes
* opt: does not elide text on tab name
* 🎨 apply clang-format changes
---------
Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-22 17:17:57 +08:00
xiaoyifang
04a58d6418
opt: dsl remove useless method and refactor langcodes logic ( #889 )
...
* opt: dsl remove useless method and refactor langcodes logic
* 🎨 apply clang-format changes
* opt: remove useless code
---------
Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-21 20:47:49 +08:00
xiaoyifang
93d475cc32
Merge pull request #882 from xiaoyifang/opt/unify-windows-icon
...
opt: unify windows icon
2023-06-20 13:43:25 +08:00
xiaoyifang
a0d8c50a52
Merge pull request #881 from shenlebantongying/macOS_slot
...
fix: macOS missing slot warning
2023-06-20 09:54:40 +08:00
YiFang Xiao
7f0cb26cda
opt: unify windows icon
2023-06-20 08:31:44 +08:00
shenleban tongying
ffe88499bb
fix: macOS missing slot warning
2023-06-19 20:17:58 -04:00
shenleban tongying
4432de9d50
clean: remove duplicated exCantReadFile definitions
...
Obviously, it is a result of copy-paste programming
2023-06-19 18:54:17 -04:00
shenleban tongying
a76ef3dfdd
guard against null img for ZIM
2023-06-19 05:01:27 -04:00
shenleban tongying
1589e14b70
clean: remove redundant dictionaryNativeIcon
...
`dictionaryNativeIcon` was intended to access the original icon before none-square icons were transformed into squares.
`dictionaryNativeIcon` is only used in dictionaryBar, but according to the intention, it shouldn't.
In reality, `dictionaryNativeIcon` is almost always equal to `dictionaryIcon`.
2023-06-18 22:37:07 -04:00
shenleban tongying
feda879a30
feat: load and display ZIM dictionary icon
...
* Original GD never tries to load zim format's icon
* This leverage the capability provided by libzim
2023-06-18 05:25:38 -04:00
shenleban tongying
9d19ea1ebc
feat: add -v --version flag to CLI
...
* also abstract version info into a standalone namespace
2023-06-17 05:00:05 -04:00
YiFang Xiao
b815f489d2
clean: remove config old code
2023-06-16 20:34:50 +08:00
xiaoyifang
16f853b68b
fix: qtimer release memory ( #863 )
...
* fix: memory leakage
2023-06-16 08:37:33 +08:00
shenleban tongying
35f39ea7a0
clean: convert a few trivial old SIGNAL/SLOT to new syntax
2023-06-11 11:27:49 -04:00
xiaoyifang
7e93d787b5
Merge pull request #852 from shenlebantongying/no_SIGNAL_scanpopup
...
clean: convert Scanpopup edictGroupRequested to new syntax
2023-06-11 23:20:16 +08:00
shenleban tongying
b882ecb76c
clean: convert Scanpopup edictGroupRequested to new syntax
...
* old code has a SIGNAL and a SLOT both named editGroupRequested'
* rename the SIGNAL to editGroupRequest to avoid this ambiguity
2023-06-11 10:17:20 -04:00
YiFang Xiao
318e186215
fix: slob fullindex will freeze the preference dialog
2023-06-11 21:33:25 +08:00
shenleban tongying
f14d28d193
clean: convert MainWindow::addGlobalAction SLOT to new syntax
...
Historical context: `MainWindow::addGlobalAction` was invented by
https://github.com/goldendict/goldendict/pull/482/files
2023-06-11 04:47:39 -04:00
xiaoyifang
ca4664f209
fix: possible crash ( #836 )
...
* fix: possible crash when show statusbar message
* windows qt upgrade to qt6.5.1
* Update src/ui/mainstatusbar.cc
---------
Co-authored-by: YiFang Xiao <yifang.xiao@noreply.com>
2023-06-10 22:26:24 +08:00
xiaoyifang
dfd3a86c7f
fix: fulltext remove query word size check ( #845 )
...
* fix: fulltext remove query word size check
* fix: remove unused methods
* 🎨 apply clang-format changes
---------
Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-10 21:02:22 +08:00
shenlebantongying
ab7af55696
update initializing.ui & splash img
2023-06-10 07:40:17 -04:00
xiaoyifang
a688a08eb1
Merge pull request #843 from xiaoyifang/feature/splash-2
...
feat: make initialize ui more human-friendly
2023-06-10 18:25:48 +08:00
YiFang Xiao
90b89acac0
feat: make initialize ui more human-friendly
2023-06-10 16:57:49 +08:00
YiFang Xiao
799370f5ef
fix: adjust margin around dictionary group
2023-06-10 14:45:48 +08:00
xiaoyifang
9c1a77a3f8
fix regression: select translation line text when got focused ( #841 )
...
* fix: select translation line text when got focused
* 🎨 apply clang-format changes
* fix: code smells
---------
Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-10 10:36:59 +08:00
YiFang Xiao
fc08c16479
fix: merge history items when import history items
2023-06-09 21:57:09 +08:00
YiFang Xiao
04ed15434e
fix: remove duplicate logic
2023-06-09 21:36:12 +08:00
xiaoyifang
8ecf3b6cbc
Merge pull request #837 from xiaoyifang/opt/dsl-old-logic
...
fix: dsl remove too old code logic
2023-06-09 20:11:08 +08:00
xiaoyifang
f02fc350f8
fix: keep the application name unchanged for now ( #835 )
...
fix: Windows autostart reg entry use GoldenDict as entry name
2023-06-09 19:56:51 +08:00
xiaoyifang
9d047fea61
fix: add an --reset-windows-state option to command line ( #829 )
...
* fix: add an --reset-windows-state option to command line
* add an option
2023-06-09 19:56:04 +08:00
YiFang Xiao
6a7dd65728
fix: remove too old code logic
...
reasons:
1. if the replacement is important ,then the code should not care about the length (size() < 70)
2. ' ' has been replaced with uC2A0 which is incorrect. u00A0 is expected.
2023-06-09 19:53:34 +08:00
xiaoyifang
67ed24c61c
fix: support dsl dictionary utf encoding detection ( #830 )
...
* fix: support dsl dictionary utf encoding detection
* fix: code smells
* fix: code smells
* 🎨 apply clang-format changes
* fix: adjust linefeed
---------
Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-09 08:01:45 +08:00
YiFang Xiao
c56304a2b9
fix: remove toggle main windows extra parameter
...
the parameter has no use right now
2023-06-08 08:30:23 +08:00
YiFang Xiao
70cd2f937d
fix: remove unused configuration
2023-06-07 23:49:27 +08:00
YiFang Xiao
47cc3ced1f
fix: remove the context line parameter
...
in release mode, this parameters are empty
2023-06-07 21:58:59 +08:00
xiaoyifang
f58eb43bd2
opt: use QFontCombox instead ( #781 )
...
* opt: use QFontCombox instead
* 🎨 apply clang-format changes
* remove comment code
---------
Co-authored-by: xiaoyifang <xiaoyifang@users.noreply.github.com>
2023-06-07 21:53:21 +08:00