23,096 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
John Studnicka	ecede3875b	lint: Add .clang-tidy and analyzer scripts ... Signed-off-by: John Studnicka <contact@zentec.dev>	2026-05-26 12:15:17 +02:00
Aggelos Tselios	1e0c1fa022	os: client: rename get_argmax_fptr to get_argmax_from_kern ... the _fptr suffix is used in other parts when they replaced apple blocks functionality. However in this case a more descriptive name is better (since this function can technically be reused in other places in the future) Signed-off-by: Aggelos Tselios <aggelostselios777@gmail.com>	2026-05-23 11:30:04 +02:00
Aggelos Tselios	ab31666079	os: client: replace apple block with proper function ... Replace an apple block in DetermineClientCmd with a regular C function, in the part responsible for fetching argmax from the kernel on Apple systems. Signed-off-by: Aggelos Tselios <aggelostselios777@gmail.com>	2026-05-23 11:30:04 +02:00
Aggelos Tselios	0251ab31a5	hw: xquartz: Purge Apple blocks from X11Application.m ... Purge every instance of Apple blocks from hw/xquartz/X11Application.m and replace them with simple C functions that no longer require the blocks extension from clang or older versions of GCC. Signed-off-by: Aggelos Tselios <aggelostselios777@gmail.com>	2026-05-23 11:30:04 +02:00
Aggelos Tselios	93030a188f	hw: xquartz: Rewrite XQuartzDefaults without Apple blocks ... Rewrite most of the source code of hw/xquartz/NSUserDefaults+XQuartzDefaults.m to use proper C functions instead of Apple blocks. Nothing should change functionally. Signed-off-by: Aggelos Tselios <aggelostselios777@gmail.com>	2026-05-23 11:30:04 +02:00
Aggelos Tselios	1fd688b643	hw: xquartz: remove apple block extension code ... Apple blocks are an extension specific to some very old GCC versions and clang. Replace them by writing proper functions and using function pointers in their place. Signed-off-by: Aggelos Tselios <aggelostselios777@gmail.com>	2026-05-23 11:30:04 +02:00
Enrico Weigelt, metux IT consult	2577cc1d1e	.github: ubuntu: use apt-cache also for *BSD builds ... also cache qemu et al. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-22 20:45:43 +02:00
Enrico Weigelt, metux IT consult	0112184a44	.github: ubuntu: don't install libnvidia-egl-wayland-dev anymore ... This package isn't needed anymore, since xwayland removal. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-22 20:25:55 +02:00
Enrico Weigelt, metux IT consult	fdd79ba7e6	.github: update actions/cache/restore to v5 ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-22 19:43:18 +02:00
Enrico Weigelt, metux IT consult	e1377cf2b2	.github: ubuntu: don't install wayland libs ... Xwayland is long gone, so no need for those anymore. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-22 19:27:20 +02:00
Peter Hutterer	1b32a6850a	randr/rrsdispatch: reject invalid format in SProcRRChangeProviderProperty ... No real effect here since we check stuff->format early in ProcRRChangeProviderProperty anyway. But this just makes it a bit more obvious (and more consistent with other functions). Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2200> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-22 14:04:52 +02:00
Enrico Weigelt, metux IT consult	c6145962ff	.github: xserver: use actions/cache@v5 ... v4 is running on outdated nodejs-20, which will be disabled soon (forced to run on nodejs-24 instead). Thus it's better to upgrade to v5, which is designed to run on nodejs-24. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-22 14:04:39 +02:00
stefan11111	961eeeeb39	glamor/glamor_egl: Log about active EGLDisplays not in usedlist ... Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-22 13:40:19 +02:00
stefan11111	1551aa1c34	glamor/glamor_egl: Rename FreeDisplayList to UsedDisplayList ... It's a list of displays still in use, not of unused displays Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-22 13:40:19 +02:00
stefan11111	c44d9e90bb	glamor/glamor_egl: Write the EGLDisplay freelist in a more elegant way ... Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-22 13:40:19 +02:00
Enrico Weigelt, metux IT consult	1ef0db61c3	.github: ubuntu: fix apt cache ... The previous approach flooded the repository with new caches, thus leading to unnecessary eviction of other caches. Previously had splitted restore and save, but that required using separate keys, and github doesn't report partial cache hits (prefix-only), thus no chance of skipping unnecessary cache saves. Instead now moving out populating the cache into a separate job, which is run before all those who need the cache. This also allows us skipping `apt-get update` in the individual jobs, thus saving a bit more time. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-22 10:01:05 +02:00
stefan11111	c64d7da59b	kdrive/fbdev: Properly handle a first -screen argument ... If the first argument is `-screen`, the first screen is explicit, so we don't need to create it twice Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-21 20:32:57 +02:00
stefan11111	f96c5d1fcc	CI: Add job for building without gbm ... This is a path that is not very tested, so bugs can easily slip through Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-21 20:32:54 +02:00
stefan11111	f6d7e8c3ef	meson: Add -Dgbm build option ... Allow libgbm to be explicitly enabled/disabled. Useful for testing (and maybe packaging). Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-21 20:32:54 +02:00
Peter Hutterer	936366bf18	Xi: add missing gesture grab type checks in ProcXIPassiveUngrabDevice ... ProcXIPassiveUngrabDevice was missing XIGrabtypeGesturePinchBegin and XIGrabtypeGestureSwipeBegin from its detail!=0 rejection check. The corresponding ProcXIPassiveGrabDevice function correctly includes these gesture types. Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2197> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 20:32:43 +02:00
Peter Hutterer	cfde872ef4	Xi/exevents: fix off-by-one in UpdateDeviceState valuator bounds check ... There is no OOB write, the loop a few lines below has the correct i < numAxes check. But this does set last_valuator to an invalid value which may have flow-on effects elsewhere later. Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2200> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 18:36:26 +02:00
Peter Hutterer	bd0dbe12a8	xkb: Fix off-by-one and NULL dereferences in _CheckSetOverlay() ... Off-by-one in rowUnder validation: the bounds check uses '>' instead of '>=' when comparing rWire->rowUnder against section->num_rows. Since num_rows is a count and valid indices are 0 to num_rows-1, rowUnder == num_rows passes the check but is one past the valid range. XkbAddGeomOverlayRow() uses this as an array index, causing an out-of-bounds read on section->rows[]. And throw in two alloc checks while we're at it. Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2208> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 18:36:18 +02:00
Peter Hutterer	e24510917a	xkb: Fix out-of-bounds array access in _CheckSetShapes() ... The primaryNdx and approxNdx fields in the shape wire description are attacker-controlled CARD8 values from the client request. They are used to index into the shape->outlines[] array, but were only checked against XkbNoShape (0xff) and never validated against the actual number of outlines (shapeWire->nOutlines). Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2208> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 18:35:55 +02:00
Enrico Weigelt, metux IT consult	a7310e147c	os/auth: fix error paths when reading from /dev/urandom ... Handle /dev/urandom errors while reading, otherwise the MIT-MAGIC-COOKIE-1 authentication cookies contains unintialized data (which both can leak data and allows predicting the value). Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2200> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 17:13:24 +02:00
stefan11111	03a7e3c51e	glamor/glamor_egl: Add a fallback path to glamor_gbm_bo_from_pixmap_internal ... nvidia's gbm backend has issues dealing with importing a gbm bo directly from an EGLImage This exports the image as dmabufs and imports a bo from dmabufs This fixes DRI3 export on nvidia, but it is a terrible implementation. A better implementation can be found here: https://github.com/X11Libre/xserver/pull/2732 See: https://gitlab.freedesktop.org/mesa/mesa/-/work_items/14047#note_3475566 Fixes: https://github.com/X11Libre/xserver/issues/1202 Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-21 17:01:29 +02:00
Peter Hutterer	cf1d9423db	xkb: Fix out-of-bounds array access in xkmread.c ReadXkmGeometry ... The primary_ndx and approx_ndx fields from the XKM shape wire description are used as indices into the shape->outlines[] array without bounds checking against num_outlines. Exploiting this (if it can be exploited) requires a malicious xkbcomp - the path of which is built-in at compile time. There are lower-hanging targets than trying to exploit through an XKM file. Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2207> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 17:00:28 +02:00
Peter Hutterer	1e6f50853e	render: fix memory leaks on XaceHook failure in resource creation ... Same pattern for all hunks here: if Xace fails, free the allocated data. Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2205> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 16:59:36 +02:00
Peter Hutterer	53370c3caa	xkb: Fix off-by-one in color index validation in _CheckSetGeom() ... The bounds checks for baseColorNdx and labelColorNdx in _CheckSetGeom() use '>' instead of '>=' when comparing against req->nColors. Since nColors is a count and valid indices are 0 to nColors-1, an index equal to nColors is one past the end of the array. Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2208> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 16:59:09 +02:00
Peter Hutterer	ddf5ec99fc	glx: reject negative size in FeedbackBuffer and SelectBuffer requests ... Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2206> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 16:50:52 +02:00
Peter Hutterer	8fb63dcf23	present: actually return the created notifies ... present_create_notifies() creates an array of notifies but never returns them to the caller, despite them being passed individually to present_add_window_notify(). The caller proceeds with a NULL notifies array, eventually causing an OOB in present_vblank_notify() when vblank->notifies is NULL. Reported-by: Feng Ning, Innora Pte. Ltd. Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2204> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 16:50:34 +02:00
Peter Hutterer	8b947b4db9	cursor: fix AllocARGBCursor leak/double-free for psrcbits/pmaskbits/argb ... AllocARGBCursor took ownership of the psrcbits/pmaskbits/argb arguments. But if the initial calloc failed none of them were freed, without the caller knowing about it. Depending on the code path, those arguments would thus either leak or be double-freed. Fix it by always freeing those on error and updating the callers accordingly. Assisted-by: Claude:claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2214> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-21 16:50:29 +02:00
Olivier Fourdan	b45e5ebc34	config: Fix build with udev disabled ... Commit b5b52979 has split the options "udev" and "udev_kms" for systems without systemd. Yet, when building with "-Dudev=false", "udev_kms" still defaults to true. That breaks the build because "config_udev_odev_probe()" is not defined: | config/config.c: In function ‘config_odev_probe’: | config/config.c:77:5: error: implicit declaration of function | ‘config_udev_odev_probe’; did you mean | ‘config_odev_probe’? | [-Wimplicit-function-declaration] | 77 | config_udev_odev_probe(probe_callback); | | ^~~~~~~~~~~~~~~~~~~~~~ | | config_odev_probe | config/config.c:77:5: warning: nested extern declaration of | ‘config_udev_odev_probe’ [-Wnested-externs] Yet, the code of the function "config_udev_odev_probe()" in config/udev.c is within a "#ifdef udev_kms" conditional, so it is built. The problem is that the function definition is within an "#ifdef udev" in the "config_backends.h" header. So, even though the actual code is compiled, the compiler will fail to find the function definition, hence the "implicit declaration" error. To avoid the issue, move the function definition within a separate "udev_kms" conditional in the "config-backends.h" header file. Closes: https://gitlab.freedesktop.org/xorg/xserver/-/work_items/1890 Fixes: b5b52979 ("meson: split udev from udev_kms which requires systemd") Signed-off-by: Olivier Fourdan <ofourdan@redhat.com> Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2203>	2026-05-20 20:01:30 +02:00
Peter Hutterer	cd2f6a0f19	os/auth: prefer getrandom() over arc4random_buf() and /dev/urandom ... Use getrandom() as the preferred source of random data when available, getrandom() works in chroots and containers without the random device node. Note this is a build-time preference, not a runtime preference. Assisted-by: Claude:claude-claude-opus-4-6 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2200> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-20 19:50:09 +02:00
Enrico Weigelt, metux IT consult	0005acde2d	.github: ubuntu: parallel driver build ... Parallel build of the drivers on Ubuntu target. Dependencies are built only once and taken from cache by the individual driver builds. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-20 14:44:02 +02:00
Enrico Weigelt, metux IT consult	777d0806a4	.github: use action "ubuntu-install-pkg" for all builds on Ubuntu ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-18 20:19:12 +02:00
Enrico Weigelt, metux IT consult	717cf92ba7	.github: ubuntu: move apt install & caching into separate action ... subsequent commits will reuse this action in other places, too. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-18 20:01:10 +02:00
Enrico Weigelt, metux IT consult	b37865cc93	.github: xserver-ubuntu: make apt-cache actually work ... Using separate restore and save steps in order to save the cache as soon as possible, instead of relying on the post-action working properly. For accessing the apt cache files, we need to chmod +S /bin/tar, because it needs to run as root, and cache action doesn't have an sudo option. Note: we need to store the cache with some unique ID (and restore from common prefix), otherwise getting with Github's cache API - it seems to lock the cache key as soon as it's retrieved once. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-18 19:27:33 +02:00
Enrico Weigelt, metux IT consult	a7dc851e5d	.github: ubuntu-drivers: install Xserver to X11_PREFIX ... Install our own xserver build into X11_PREFIX (/home/runner/x11) instead of /usr. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-18 16:08:29 +02:00
Enrico Weigelt, metux IT consult	d5aee84480	.github: drop chmod on /bin/tar ... This was a workaround for buggy older Ubuntu CI images that's not needed anymore. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-18 15:46:38 +02:00
stefan11111	8f91ecf994	kdrive/fbdev: Print some info about the video card mode ... Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-18 14:18:58 +02:00
stefan11111	c2bc397d7f	kdrive/fbdev: Fix potential NULL-pointer derefernce on some error paths ... Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-18 14:18:58 +02:00
Enrico Weigelt, metux IT consult	58cedffac1	xkb: improve error messages ... Make error messages on failed childbuf size check more clear on where the problem is coming from. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-18 13:55:39 +02:00
stefan11111	9b8efe2caa	kdrive/fbdev: Write the KEYBOARD man page section ... documenting special key combinations Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-18 10:20:40 +02:00
stefan11111	fa98a5792c	kdrive: Implement vt switching for vts 11 and 12 ... Signed-off-by: stefan11111 <stefan11111github@gmail.com>	2026-05-18 10:20:40 +02:00
Enrico Weigelt, metux IT consult	94ec00cb11	drop remains of old f.d.o gitlab pipeline ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-16 13:30:19 +02:00
Enrico Weigelt, metux IT consult	1ce321bed5	.github: use actions/checkout@v6 ... v4 is based on nodejs-20, which is obsolete on github. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-16 13:30:09 +02:00
Enrico Weigelt, metux IT consult	b5dbad8be3	.github: drivers/ubuntu: move xserver build into prereq script ... Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-15 21:42:25 +02:00
Enrico Weigelt, metux IT consult	bfdffa8f00	.github: ubuntu: install-pkg.sh: install extra packages ... Install some needed packages which are only installed on Github's VM images, but missing in Ubuntu containers. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-15 19:46:00 +02:00
Enrico Weigelt, metux IT consult	70f4ec5fd4	.github: move compile-drivers.sh under ubuntu/ ... It's only used on Ubuntu, so move it accordingly. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-15 19:11:22 +02:00
Enrico Weigelt, metux IT consult	d34e7983a5	.github: move install-prereq-drivers.sh under ubuntu/ ... It's only used on Ubuntu, so move it accordingly. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>	2026-05-15 19:03:47 +02:00