xserver/fb
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Jeremy Huddleston Sequoia 3d20b6d253 fb: Don't widen the planemask over padding bits when ROOTLESS_SAFEALPHA is set
Wide LineDoubleDash lines drew black on screen under XQuartz while the server's own XGetImage readback showed the
correct pixels, because at depth 24 that readback ignores alpha. Opaque text and dashed arcs take the same path.

fbValidateGC widens a planemask that covers the drawable's depth to cover its full bits per pixel, so the blit and
fill paths can take their all-ones shortcuts. On a rootless server that also writes the alpha channel of the window's
premultiplied surface, which CoreGraphics then composites as black. Rootless keeps that alpha opaque by clearing the
bits from the planemask, but only its own ValidateGC does so, and mi revalidates the GC in the middle of a drawing
operation to swap the foreground for the background pixel. By then the damage layer has unwrapped the rootless funcs
down to fb, so the reassertion never happens and the rest of the operation lands with a zero alpha channel.

Fixes: https://github.com/XQuartz/XQuartz/issues/230

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2026-09-30 19:06:39 +02:00
..
fb_priv.h license: add X11 OR MIT OR AGPL-3.0-or-later to Enrico Weigelt's source files 2026-07-29 10:02:59 +02:00
fballpriv.c
fbarc.c
fbbits.c
fbbits.h fb: parentheses around macro argument symbols 2026-06-25 06:53:59 +02:00
fbblt.c fb: Avoid potential out-of-bounds shift amounts in fbBlt 2026-08-31 15:51:17 +02:00
fbbltone.c fb: use stdbool's 'bool' instead of 'Bool' for local variables 2026-08-07 14:24:27 +02:00
fbcmap_mi.c
fbcopy.c
fbfill.c
fbfillrect.c
fbfillsp.c
fbgc.c fb: Don't widen the planemask over padding bits when ROOTLESS_SAFEALPHA is set 2026-09-30 19:06:39 +02:00
fbgetsp.c
fbglyph.c fb: use stdbool's 'bool' instead of 'Bool' for local variables 2026-08-07 14:24:27 +02:00
fbimage.c treewide: fix result type of BitmapBytePad() to size_t 2026-06-29 15:44:48 +02:00
fbline.c fb: use stdbool's 'bool' instead of 'Bool' for local variables 2026-08-07 14:24:27 +02:00
fboverlay.c fb: quiet -Wanalyzer-out-of-bounds warnings in fbOverlayCopyWindow() 2026-04-21 12:19:30 +02:00
fbpict.c render: move it under Xext/ 2026-06-17 14:29:57 +02:00
fbpict_priv.h license: add X11 OR MIT OR AGPL-3.0-or-later to Enrico Weigelt's source files 2026-07-29 10:02:59 +02:00
fbpixmap.c fb: use stdbool's 'bool' instead of 'Bool' for local variables 2026-08-07 14:24:27 +02:00
fbpoint.c
fbpush.c
fbscreen.c
fbseg.c fb: use stdbool's 'bool' instead of 'Bool' for local variables 2026-08-07 14:24:27 +02:00
fbsetsp.c
fbsolid.c fb: parentheses around macro argument symbols 2026-06-25 06:53:59 +02:00
fbtile.c
fbtrap.c treewide: clean up includes of mipict.h 2026-04-30 14:51:33 +02:00
fbutil.c
fbwindow.c
meson.build